[cfe-commits] r151910 - in /cfe/trunk: include/clang/Basic/Version.h lib/Basic/Makefile lib/Basic/Version.cpp

[Andrew Trick]

On Mar 2, 2012, at 9:03 AM, Charles Davis <cdavis at mymail.mines.edu> wrote:

> Hi Liu,
> 
> On Mar 2, 2012, at 7:37 AM, Jia Liu wrote:
> 
>> Author: jialiu
>> Date: Fri Mar  2 08:37:41 2012
>> New Revision: 151910
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=151910&view=rev
>> Log:
>> clang -v support for separate clang.git and llvm.git, patch by Andrew Trick.
> You do realize that he has commit access, right? You didn't have to commit this for him.
> 
> There's a very good reason he sent this patch to the list: he wanted to discuss it first. He wasn't sure that this was a desirable change, so he wanted to see what people thought of it before he committed it.
> 
> Besides, you broke the build by converting some tabs to spaces in a makefile. Normally we prefer spaces to tabs, but makefiles must use tabs in recipes (the lists of commands to execute to make the targets). Did you even test this change before you committed it? This time someone caught this and fixed it for you, but next time you might get an angry email from someone saying "this commit broke the build, please revert or fix".
> 
> I understand you have good intentions, but in the future, please don't commit patches haphazardly like this.

I totally missed that this was committed for me. Thanks Jia Liu, now I don't have to wait for review. It looks like editing the patch file stripped tabs so that's partially my fault. The usual testing may not have caught it if the rule wasn't triggered.

Sorry it caused trouble. A quick revert is always a valid response.

-Andy