[cfe-commits] [patch] Warn in string literal + integral

[Nico Weber]

> Thanks, this looks fine to commit.

Thanks, r151943.

>> > Other than that, a test for the fix-it would be great (see test/FixIt
>> > for
>> > examples).
>>
>> Wouldn't that require the fixit to be on the warning instead of the
>> note? (If so, maybe there's no need for the test yet?)
>
>
> You can test fixits on notes with -fdiagnostics-parseable-fixits +
> FileCheck. See test/FixIt/fixit-vexing-parse.cpp for an example of that. I'm
> happy for that to be a subsequent commit.

Attached. I added only a test for the first fixit since having lots of
line numbers hardcoded in the test would probably make the test more
annoying than useful. Is this what you had in mind?

Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-str-plus-int-fixit-test.patch
Type: application/octet-stream
Size: 1208 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120302/87a58fa7/attachment.obj>