[cfe-commits] [patch] Allow redefining c++ operators like "and" in ms mode

Nico Weber thakis at chromium.org
Wed Feb 29 14:59:42 PST 2012


Given the smallness of the patch, I went ahead and landed this in r151768.

On Tue, Feb 28, 2012 at 8:14 PM, Nico Weber <thakis at chromium.org> wrote:
> I enabled this always locally and ran all clang tests. They all pass,
> except for test/Preprocessor/cxx_oper_keyword.cpp which specifically
> tests that "and" and co can't be redefined. So this should be fine?
>
> Nico
>
> On Mon, Feb 27, 2012 at 9:42 PM, Nico Weber <thakis at chromium.org> wrote:
>> Hi,
>>
>> the attached patch allows things like `#define and foo` in ms mode.
>> This fixes PR10606.
>>
>> I'm not sure if this is the right approach: Preprocessor.cpp sets does
>> setIdentifierInfo(0) for isCPlusPlusOperatorKeyword()s, and my patch
>> sets it back to a "real" identifier info just in time before it's
>> needed in ReadMacroName().
>>
>> Nico



More information about the cfe-commits mailing list