[cfe-commits] [libcxx] r151720 - in /libcxx/trunk: CREDITS.TXT include/__config include/__locale include/cmath include/cstdlib include/cstring src/locale.cpp src/random.cpp src/thread.cpp

[Howard Hinnant]

On Feb 29, 2012, at 11:27 AM, David Chisnall wrote:

>> If you can just search on "#" and review the matching comments, it would be much appreciated.
> 
> I think they're correct aside from that one - although I may still be hiding a few too many declarations on Solaris.  Unfortunately, Sun decided to randomly put about half of the C++ things that are present in C headers in the std:: namespace, but didn't bother with the other half.  

#ifndef __sun__  // line 1422

appears to match with:

#endif // !_MSC_VER  // line 1600

Please do a full review.  I can't tell what was intended.  I only know that things are not broken on APPLE, but that the file does not appear to do what was intended.

Thanks,
Howard