[cfe-commits] [patch][pr12001] Avoid increasing visibility in some cases

[Nico Weber]

On Mon, Feb 20, 2012 at 4:24 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> 2012/2/19 Nico Weber <thakis at chromium.org>:
>> Thanks, Rafael!
>>
>> I verified that the components build of chromium/linux, and the
>> "normal" build of chromium/linux and mac continue to work. In
>> addition, the components build of chromium/mac starts to work with
>> this patch (with some changes on the chromium side). Hooray :-)
>
> What changes were needed on your side?

Nothing interesting, mostly just adding visibility("default")
attributes to a few functions, cleaning up library dependencies, etc
(http://crbug.com/90078 and http://codereview.chromium.org/7484017/
mostly).
>
>> The patch looks similar what I was trying locally, so as far as I can
>> tell it looks good. (You have more testcases though :-) ).
>
> Yes, I started with your patch, but moved the logic to a new function.
>
>> Nico
>
> Cheers,
> Rafael