[cfe-commits] [PATCH 2/5] [clang.py] Implement Type.__eq__ and Type.__ne__

[Manuel Klimek]

Looks good.

On Sat, Feb 18, 2012 at 8:26 PM, Gregory Szorc <gregory.szorc at gmail.com> wrote:
> I've made the implementation of Type.__eq__ more robust and added tests.
>
>
> On Fri, Feb 17, 2012 at 1:37 AM, Manuel Klimek <klimek at google.com> wrote:
>>
>> On Fri, Feb 17, 2012 at 8:56 AM, Gregory Szorc <gregory.szorc at gmail.com>
>> wrote:
>> > The implementation could probably be a bit more robust (looking for
>> > None, comparing types, etc). Do we care?
>>
>> Regarding looking for None: what happens if one calls t == None on a
>> Type? Perhaps add a test?
>>
>> Cheers,
>> /Manuel
>>
>>
>> > ---
>> >  bindings/python/clang/cindex.py           |   10 ++++++++++
>> >  bindings/python/tests/cindex/test_type.py |   17 +++++++++++++++++
>> >  2 files changed, 27 insertions(+), 0 deletions(-)
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> >
>
>