[cfe-commits] [Patch] New warning for scopes that start in one file and end in another.
sebastian.redl at getdesigned.at
Thu Feb 16 02:46:07 PST 2012
On 16.02.2012, at 08:11, Matt Beaumont-Gay wrote:
> On Wed, Feb 15, 2012 at 20:47, Eli Friedman <eli.friedman at gmail.com> wrote:
>> Mechanically, the patch looks fine...
>> What sort of testing have you done with this patch? Has this caught
>> any interesting issues in existing code? If not, why is this warning
>> useful? Any false positives we should be aware of?
> I imagine that this will not have a lot of hits on checked-in code.
> However, I can see it being very useful during development, e.g. when
> you forget to close a namespace at the bottom of a header file.
But you'd most likely get an error anyway, complaining about unmatched braces. Unless there just happens to be another, fitting, unmatched brace in each source file that includes the header.
More information about the cfe-commits