[cfe-commits] [patch] Make it so that some warnings in DiagGroup<"all"> aren't on by default

Chris Lattner clattner at apple.com
Wed Feb 15 03:14:54 PST 2012


What is the motivation for this patch?  Clang defaulting to more warnings on than gcc is a feature, not a bug.

-Chris

On Feb 14, 2012, at 6:28 PM, Nico Weber <thakis at chromium.org> wrote:

> Hi,
> 
> -Wall is defined like this:
> 
>  def : DiagGroup<"all", [Most, Parentheses, Switch]>;
> 
> This makes sense, but _all_ of the warnings in Parentheses and Switch
> are on by default, so -Wall is currently identical to -Wmost. With
> this patch, some of the warnings in that group become DefaultIgnore,
> so that they are only active if -Wall is specified. It looks like that
> was the intention for most of them, but since DiagGroup<"all"> is a
> bit confusing in this regard, they got always-enabled by accident (as
> far as I can tell).
> 
> Ok?
> 
> Nico
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list