[cfe-commits] [patch] Make it so that some warnings in DiagGroup<"all"> aren't on by default

Nico Weber thakis at chromium.org
Tue Feb 14 18:43:13 PST 2012


Now with many percent more patch attached.

On Tue, Feb 14, 2012 at 6:28 PM, Nico Weber <thakis at chromium.org> wrote:
> Hi,
>
> -Wall is defined like this:
>
>  def : DiagGroup<"all", [Most, Parentheses, Switch]>;
>
> This makes sense, but _all_ of the warnings in Parentheses and Switch
> are on by default, so -Wall is currently identical to -Wmost. With
> this patch, some of the warnings in that group become DefaultIgnore,
> so that they are only active if -Wall is specified. It looks like that
> was the intention for most of them, but since DiagGroup<"all"> is a
> bit confusing in this regard, they got always-enabled by accident (as
> far as I can tell).
>
> Ok?
>
> Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-wall.patch
Type: application/octet-stream
Size: 3533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120214/f0593dbf/attachment.obj>


More information about the cfe-commits mailing list