[cfe-commits] [PATCH][PR11329][v14] Generalize -Wempty-body: warn when statement body is empty

Dmitri Gribenko gribozavr at gmail.com
Tue Feb 14 14:01:14 PST 2012

On Tue, Feb 14, 2012 at 8:44 PM, Argyrios Kyrtzidis <kyrtzidis at apple.com> wrote:
> Well, at least it doesn't change previous behavior, clang was already warning on "if"s with empty semicolon, so please go ahead and commit your patch, we can always revisit whether we should revise how this case is handled later on.

Thank you for your reviews.

Before I commit, how should I deal with the noisy false positive in
llvm/CodeGen/MachineDominators.h?  Should I just commit the trivial
fix (attached) or a post to llvm-commits is necessary?


(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: machine-dominators-h-empty-body.patch
Type: text/x-diff
Size: 578 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120215/140074ef/attachment.patch>

More information about the cfe-commits mailing list