[cfe-commits] [LLVMdev] clang errors on void main()

John McCall rjmccall at apple.com
Tue Feb 14 11:58:06 PST 2012

On Feb 14, 2012, at 7:10 AM, Vasiliy Korchagin wrote:

> 14.02.2012 05:20, John McCall пишет:
>> On Feb 13, 2012, at 4:38 PM, John McCall wrote:
>>> On Feb 11, 2012, at 7:31 AM, Vasiliy Korchagin wrote:
>>>> I agree, without setting implicit return zero bit changes in codegen are not necessary. New version of patch is attached.
>>> This check has nothing to do with C99.  You should be checking for "has GNU extensions" and "is not C++", i.e.
>>>  getLangOptions().GNU&&  !getLangOptions().CPlusPlus
>> I see that I missed the later follow-ups in this thread, and you're now
>> checking CPlusPlus correctly.  Please do also check for GNU
>> extensions being enabled and implement this:
>>> Also, please have CheckMain just set hasImplicitReturnZero() as appropriate and then make actOnFinishFunctionBody disable fall-through checking when that bit is set.
>> With that, this should be fine.
>> John.
> I fixed the patch. New patch is attached.

I tweaked this and committed it as r150500, thanks!


More information about the cfe-commits mailing list