[cfe-commits] r150215 - in /cfe/trunk: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/malloc-annotations.c test/Analysis/malloc.c

[Jordy Rose]

On Feb 10, 2012, at 8:11, Anna Zaks wrote:

>   ProgramStateRef state = C.getState();
> +  if (!isa<DefinedOrUnknownSVal>(location))
> +    return;

location.isUndef() might be a little prettier, for all of the instances of this in the commit. It's not nice that we have to do this though...it's sort of boilerplate code for ANY argument in a post-call checker. What do you (and Ted, and everyone) think about skipping post-call checks if any arguments are undefined? (Unknown is okay, of course.)

When does this happen, anyway? Your test case should hit the "not-a-symbolic-region" error, but I don't know about the undefined argument value.

Jordy