[cfe-commits] [PATCH] cmake: create a relative symlink to clang

[Chandler Carruth]

On Fri, Feb 3, 2012 at 7:20 AM, Rafael Espíndola <rafael.espindola at gmail.com
> wrote:

> > I'm talking about the symlink to clang from clang++, though, which is
> > what's busted. I think CMake handles the clang -> clang-3.1 stuff
> > internally.
>
> Ah, sorry.
>
> Looks like this gets fixed on install already, but it is probably nice
> to always use relative symlinks.
>
> Chandler, any concerns about this patch. Is it OK?


Sorry for the backlog, conference and committee have delayed my reviews.

I'm fine in principle. A few issues w/ the patch:

+# Create a relative symlink
+ set(clang_binary "./clang${CMAKE_EXECUTABLE_SUFFIX}")

I don't think you want a "./" in the symlink name. Relative symlinks like
this usually consist just of the name. Does that not work for any reason?
It would make it consistent with the clang -> clang-3.1 symlink.

With that fix, as long as it works, LGTM and please commit.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120208/49729bd1/attachment.html>