[cfe-commits] r150055 - in /cfe/trunk: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td test/Sema/switch.c

[Ted Kremenek]

On Feb 8, 2012, at 10:17 AM, David Blaikie wrote:

> I'm also reminded of Chandler's talk at GoingNative last week when he
> mentioned that the -Wparentheses warning didn't used to have the
> inverse (checking that you /don't/ use extra () when you're just doing
> an equality not an assignment) & this was added. But I know it's not a
> perfect analogy because the extra () were already
> deliberately/habitually for -Wparentheses in the first place. Good
> that we could have negative & positive warnings on at the same time by
> default in that case.

A fair point.  I think it's worth pointing out that a fair number of people disliked this change, so much that they requested that we could put the inverse case under a different warning flag so they could turn it off.

I'm leaning that this should be under -Wall after all, but it would be great to hear other opinions here.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120208/2f132cbf/attachment.html>