[cfe-commits] r149973 - /cfe/trunk/lib/CodeGen/BackendUtil.cpp

[Bill Wendling]

On Feb 7, 2012, at 11:42 AM, David Blaikie <dblaikie at gmail.com> wrote:

> On Tue, Feb 7, 2012 at 11:36 AM, Bill Wendling <isanbard at gmail.com> wrote:
>> Hi David,
>> 
>> I thought about SmallVector as well, but I didn't want to make anything but cosmetic changes (which would hopefully result in compile time improvements).
> 
> Fair enough - I'd be surprised if the perf difference here was
> observable (but it'd be great if it does improve things) are you
> actually trying to observe an improvement (or observed a profile where
> this was costly before your change) here or just saw it & figured it
> couldn't hurt?
> 
A bit of both. There is a small improvement in compile time at -O0 (on the order of hundredths/thousandths of seconds). Nothing major, but definite add up on larger testcases.

>> These patches look good to me. (Yay! for getting rid of const_casts!) Please go ahead and apply them. Thanks! :-)
> 
> Thanks for the review - r149999 and r150000 (winner!)
> 
Yay! Thanks! :)

-bw