[cfe-commits] [PATCH] Implement Type.arguments_count through clang_getNumArgTypes

[Tobias Grosser]

On 02/05/2012 06:19 AM, Gregory Szorc wrote:
> ---
>   bindings/python/clang/cindex.py           |   10 ++++++++++
>   bindings/python/tests/cindex/test_type.py |   13 +++++++++++++
>   2 files changed, 23 insertions(+), 0 deletions(-)
Hi Gregory,

this patch looks good, but does not apply cleanly.

It seems you skipped the patch 'Implement Type.__eq__ with 
clang_equalTypes' (which I found in your git repository). The skipped 
patch would also be OK to commit - I just had a look. It is trivial.

I stopped committing here, but as it seems there are a lot more patches 
coming it is probably more convenient anyways to get you commit access.
Please follow the instructions on 
http://llvm.org/docs/DeveloperPolicy.html#commitaccess and CC me in the 
mail to Chris.

After that I propose that you still post your patches for review, but 
that you commit them yourself after an OK from our side.

Cheers
Tobi