[cfe-commits] [libcxxabi] r149522 - /libcxxabi/trunk/src/private_typeinfo.cpp

[Howard Hinnant]

Author: hhinnant
Date: Wed Feb  1 12:52:35 2012
New Revision: 149522

URL: http://llvm.org/viewvc/llvm-project?rev=149522&view=rev
Log:
Removing a TODO:  can_catch is fundamentally different than search_above_dst.  can_catch is looking for an unamiguous public base class of a specific type, but at any address.  search_above_dst is looking for an unambiguous public base class of a specific type, *and* at a specific address.  Additionally can_catch is run for all types.  search_above_dst is only run on class types.  So these are only superficially similar.  Not similar enough for resuse, at least without making the code unreadable.

Modified:
    libcxxabi/trunk/src/private_typeinfo.cpp

Modified: libcxxabi/trunk/src/private_typeinfo.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/private_typeinfo.cpp?rev=149522&r1=149521&r2=149522&view=diff
==============================================================================
--- libcxxabi/trunk/src/private_typeinfo.cpp (original)
+++ libcxxabi/trunk/src/private_typeinfo.cpp Wed Feb  1 12:52:35 2012
@@ -218,8 +218,6 @@
 // 
 // catch (...) : adjustedPtr == & of the exception
 
-// TODO:  can_catch looks similar to search_above_dst.  Reuse?
-
 bool
 __shim_type_info::can_catch(const __shim_type_info* thrown_type,
                             void*&) const