[cfe-commits] [patch] Expect 16bit type for %S in NSStrings (was Re: r148324)

[Nico Weber]

On Mon, Jan 30, 2012 at 9:46 AM, Sebastian Redl
<sebastian.redl at getdesigned.at> wrote:
>
> On 30.01.2012, at 18:37, Nico Weber wrote:
>
>>
>> The current %S warning implementation is wrong for just printf() as
>> well: It compares the argument to wchar_t, but if you build your
>> program with -fshort-wchar, clang won't warn (since your program uses
>> wchar_t) yet printf won't work (because libc was built without
>> -fshort-wchar). If you store your characters in an uint32* and pass
>> that to printf() and build your program with -fshort-wchar, clang will
>> warn (because uint32* doesn't match wchar_t* with -fshort-whar) yet
>> the program will work correctly.
>
> And just to make things more fun, Microsoft's printf takes "%S" to mean "UCS-2 string" and wprintf interprets L"%S" as "narrow string".

wchar_t is always 2 byte in Microsoft land, so -fms-extensions should
implicitly enable -fshort-wchar, which would take care of the
Microsoft part.

The attached patch lets %S, %C, and %ls look for a 16bit type in
NSStrings as discussed. OK?

Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-percent-S.patch
Type: application/octet-stream
Size: 4565 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120130/f7704f6d/attachment.obj>