[cfe-commits] r149173 - in /cfe/trunk: include/clang/Basic/Diagnostic.h lib/Basic/Diagnostic.cpp

[Argyrios Kyrtzidis]

Author: akirtzidis
Date: Fri Jan 27 22:35:52 2012
New Revision: 149173

URL: http://llvm.org/viewvc/llvm-project?rev=149173&view=rev
Log:
DiagnosticsEngine::setMappingToAllDiagnostics() does not need to return bool,
caught by Chad.

Modified:
    cfe/trunk/include/clang/Basic/Diagnostic.h
    cfe/trunk/lib/Basic/Diagnostic.cpp

Modified: cfe/trunk/include/clang/Basic/Diagnostic.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Diagnostic.h?rev=149173&r1=149172&r2=149173&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/Diagnostic.h (original)
+++ cfe/trunk/include/clang/Basic/Diagnostic.h Fri Jan 27 22:35:52 2012
@@ -479,7 +479,7 @@
   /// \brief Add the specified mapping to all diagnostics. Mainly to be used
   /// by -Wno-everything to disable all warnings but allow subsequent -W options
   /// to enable specific warnings.
-  bool setMappingToAllDiagnostics(diag::Mapping Map,
+  void setMappingToAllDiagnostics(diag::Mapping Map,
                                   SourceLocation Loc = SourceLocation());
 
   bool hasErrorOccurred() const { return ErrorOccurred; }

Modified: cfe/trunk/lib/Basic/Diagnostic.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Diagnostic.cpp?rev=149173&r1=149172&r2=149173&view=diff
==============================================================================
--- cfe/trunk/lib/Basic/Diagnostic.cpp (original)
+++ cfe/trunk/lib/Basic/Diagnostic.cpp Fri Jan 27 22:35:52 2012
@@ -295,7 +295,7 @@
   return false;
 }
 
-bool DiagnosticsEngine::setMappingToAllDiagnostics(diag::Mapping Map,
+void DiagnosticsEngine::setMappingToAllDiagnostics(diag::Mapping Map,
                                                    SourceLocation Loc) {
   // Get all the diagnostics.
   llvm::SmallVector<diag::kind, 64> AllDiags;
@@ -305,8 +305,6 @@
   for (unsigned i = 0, e = AllDiags.size(); i != e; ++i)
     if (Diags->isBuiltinWarningOrExtension(AllDiags[i]))
       setDiagnosticMapping(AllDiags[i], Map, Loc);
-
-  return false;
 }
 
 void DiagnosticsEngine::Report(const StoredDiagnostic &storedDiag) {