[cfe-commits] r148942 - in /cfe/trunk: include/clang/Driver/Driver.h lib/Driver/Driver.cpp

Chandler Carruth chandlerc at gmail.com
Wed Jan 25 00:49:22 PST 2012

Author: chandlerc
Date: Wed Jan 25 02:49:21 2012
New Revision: 148942

URL: http://llvm.org/viewvc/llvm-project?rev=148942&view=rev
Remove the TargetTriple object that I added to the Driver recently. This
helped stage the refactoring of things a bit, but really isn't the right
place for it. The driver may be responsible for compilations with many
different targets. In those cases, having a target triple in the driver
is actively misleading because for many of those compilations that is
not actually the triple being targeted.

This moves the last remaining users of the Driver's target triple to
instead use the ToolChain's target triple. The toolchain has a single,
concrete target it operates over, making this a more stable and natural
home for it.


Modified: cfe/trunk/include/clang/Driver/Driver.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Driver.h?rev=148942&r1=148941&r2=148942&view=diff
--- cfe/trunk/include/clang/Driver/Driver.h (original)
+++ cfe/trunk/include/clang/Driver/Driver.h Wed Jan 25 02:49:21 2012
@@ -102,11 +102,6 @@
   /// Information about the host which can be overridden by the user.
   std::string HostBits, HostMachine, HostSystem, HostRelease;
-  /// \brief Target triple.
-  /// Represents which platforms this driver will target at each stage of the
-  /// compilation.
-  llvm::Triple TargetTriple;
   /// The file to log CC_PRINT_OPTIONS output to, if enabled.
   const char *CCPrintOptionsFilename;

Modified: cfe/trunk/lib/Driver/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Driver.cpp?rev=148942&r1=148941&r2=148942&view=diff
--- cfe/trunk/lib/Driver/Driver.cpp (original)
+++ cfe/trunk/lib/Driver/Driver.cpp Wed Jan 25 02:49:21 2012
@@ -57,7 +57,6 @@
     DriverTitle("clang \"gcc-compatible\" driver"),
-    TargetTriple(llvm::Triple::normalize(DefaultTargetTriple)),
     CCPrintOptionsFilename(0), CCPrintHeadersFilename(0),
     CCLogDiagnosticsFilename(0), CCCIsCXX(false),
     CCCIsCPP(false),CCCEcho(false), CCCPrintBindings(false),
@@ -330,16 +329,18 @@
   if (Args->hasArg(options::OPT_nostdlib))
     UseStdLib = false;
-  // Recompute the target triple based on the args.
-  TargetTriple = computeTargetTriple(DefaultTargetTriple, *Args);
-  Host = GetHostInfo(TargetTriple);
+  // Compute the target triple based on the args, and build a Host out of it.
+  // FIXME: Yes, this makes no sense. HostInfo has little to do with the host.
+  Host = GetHostInfo(computeTargetTriple(DefaultTargetTriple, *Args));
   // Perform the default argument translations.
   DerivedArgList *TranslatedArgs = TranslateInputArgs(*Args);
+  // Owned by the host.
+  const ToolChain &TC = *Host->CreateToolChain(*Args);
   // The compilation takes ownership of Args.
-  Compilation *C = new Compilation(*this, *Host->CreateToolChain(*Args), Args,
-                                   TranslatedArgs);
+  Compilation *C = new Compilation(*this, TC, Args, TranslatedArgs);
   // FIXME: This behavior shouldn't be here.
   if (CCCPrintOptions) {
@@ -356,7 +357,7 @@
   // Construct the list of abstract actions to perform for this compilation. On
   // Darwin target OSes this uses the driver-driver and universal actions.
-  if (TargetTriple.isOSDarwin())
+  if (TC.getTriple().isOSDarwin())
     BuildUniversalActions(C->getDefaultToolChain(), C->getArgs(),
                           Inputs, C->getActions());
@@ -446,12 +447,11 @@
   // Construct the list of abstract actions to perform for this compilation. On
   // Darwin OSes this uses the driver-driver and builds universal actions.
-  if (TargetTriple.isOSDarwin())
-    BuildUniversalActions(C.getDefaultToolChain(), C.getArgs(),
-                          Inputs, C.getActions());
+  const ToolChain &TC = C.getDefaultToolChain();
+  if (TC.getTriple().isOSDarwin())
+    BuildUniversalActions(TC, C.getArgs(), Inputs, C.getActions());
-    BuildActions(C.getDefaultToolChain(), C.getArgs(), Inputs,
-                 C.getActions());
+    BuildActions(TC, C.getArgs(), Inputs, C.getActions());

More information about the cfe-commits mailing list