[cfe-commits] r148567 - /cfe/trunk/lib/Rewrite/HTMLRewrite.cpp

[Ted Kremenek]

I haven't used a Linux GUI in about 5 years, so I don't know if there is a specific difference between "Monospace" and "monospace" and whether or not this looks better than Andale Mono.  I assumed that "Monospace" was a specific font name and "monospace" was a family, and given the patch, I assumed that this looked better to the user.  I have no way to validate if this is a correct assumption.  Any recommendation for a good looking fixed width font on Linux that is fairly universal is welcome.

On Jan 21, 2012, at 5:02 AM, Sebastian Redl wrote:

> 
> On 20.01.2012, at 21:39, Ted Kremenek wrote:
> 
>> Author: kremenek
>> Date: Fri Jan 20 14:39:55 2012
>> New Revision: 148567
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=148567&view=rev
>> Log:
>> Per PR 11814, use Monospace instead of Andale Mono.
>> 
>> Modified:
>>   cfe/trunk/lib/Rewrite/HTMLRewrite.cpp
>> 
>> Modified: cfe/trunk/lib/Rewrite/HTMLRewrite.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Rewrite/HTMLRewrite.cpp?rev=148567&r1=148566&r2=148567&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Rewrite/HTMLRewrite.cpp (original)
>> +++ cfe/trunk/lib/Rewrite/HTMLRewrite.cpp Fri Jan 20 14:39:55 2012
>> @@ -292,7 +292,7 @@
>>      " body { font-family:Helvetica, sans-serif; font-size:10pt }\n"
>>      " h1 { font-size:14pt }\n"
>>      " .code { border-collapse:collapse; width:100%; }\n"
>> -      " .code { font-family: \"Andale Mono\", monospace; font-size:10pt }\n"
>> +      " .code { font-family: \"Monospace\", monospace; font-size:10pt }\n"
>>      " .code { line-height: 1.2em }\n"
>>      " .comment { color: green; font-style: oblique }\n"
>>      " .keyword { color: blue }\n"
> 
> Is there actually a difference between "Monospace" and monospace? Does the first refer to a particular font family or is it also interpreted as the generic font class?
> 
> I also don't understand the original complaint. Do Linux systems have some horrible Andale Mono font installed? Because if not, then the problem is that user's horrible fallback monospace font.
> 
> Sebastian