[cfe-commits] r148138 - in /cfe/trunk: include/clang/Driver/ lib/Basic/ lib/Driver/ test/ARCMT/ test/CodeGen/ test/CodeGenCXX/ test/Coverage/ test/Driver/ test/Frontend/ test/Headers/ test/Index/ test/Misc/ test/PCH/ test/Preprocessor/ tools/driv

[Sebastian Pop]

Hi,

On Fri, Jan 20, 2012 at 5:11 PM, Chandler Carruth <chandlerc at google.com> wrote:
> It remains really unclear why this is sufficient as a rename. I believe
> there are parts of Clang that are using this flag to mean the *host*, for
> real. I think renaming it blindly to 'target' doesn't actually make it
> represent the concept of a target. Have you audited the uses?

There is exactly one use of OPT_ccc_host_triple in the code.
I do not know what other places you think are using this flag to mean the host.
If you find places that need updating, please let me know and I'll fix that.

> Also, this patch was never actually LG'ed on the list. It should have been
> review sooner, but a ping would seem more appropriate than just
> committing...

The patch has received several comments, and I waited for reviews:
http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-January/019410.html
Of course, I welcome constructive remarks and I will work on fixing
any remaining issues with this patch.

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum