[cfe-commits] r148212 - /cfe/trunk/lib/Lex/Lexer.cpp

David Blaikie dblaikie at gmail.com
Sun Jan 15 17:23:46 PST 2012

On Sun, Jan 15, 2012 at 1:03 AM, Chandler Carruth <chandlerc at gmail.com> wrote:
> Author: chandlerc
> Date: Sun Jan 15 03:03:45 2012
> New Revision: 148212
> URL: http://llvm.org/viewvc/llvm-project?rev=148212&view=rev
> Log:
> Two variables had been added for an assert, but their values were
> re-computed rather than the variables be re-used just after the assert.
> Just use the variables since we have them already. Fixes an unused
> variable warning.

Thanks Chandler - attached are some patches for a few other release
unused variable warnings if you think they're the right fixes. (with
these fixes applied my release build is successful under -Werror -Wall
on clang (gcc unknon - I think there's at least one problem in
valgrind's headers that GCC finds when running under similar settings
(maybe even in debug+asserts as well as release)))

- David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: release_unused.diff
Type: application/octet-stream
Size: 1433 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120115/b2028652/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: release_unused_clang.diff
Type: application/octet-stream
Size: 1518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120115/b2028652/attachment-0001.obj>

More information about the cfe-commits mailing list