[cfe-commits] [PATCH] Delayed template instantiation for late-parsed attributes

Richard Smith richard at metafoo.co.uk
Fri Jan 13 14:38:59 PST 2012


On Wed, December 21, 2011 22:43, Delesley Hutchins wrote:
>> Please avoid calling the function on a null pointer, rather than checking
>> 'this' here. Such a call would have undefined behaviour by
>> [class.mfct.non-static]p2.
>
> Done.
>
>> new DeclArgumentPack(*OldPack) ?
>
> Done.
>
>> This appears to be an unrelated change?
>
> Yes -- it's a minor bugfix to thread safety attribute parsing that
> should have been in a separate patch.  :-)
>
>> The prevailing style is to put the } and else on the same line.
>
> Done.

This is fine to commit once the attribute instantiation patch lands.

Thanks!
Richard




More information about the cfe-commits mailing list