[cfe-commits] [PATCH] Skip --hash-style on Android

Chandler Carruth chandlerc at google.com
Fri Jan 13 01:07:28 PST 2012

On Fri, Jan 13, 2012 at 1:00 AM, Evgeniy Stepanov <eugeni.stepanov at gmail.com
> wrote:

> Hi,
> this patch removes --hash-style option from driver-generated link
> command line on Android. The reason is that Android linker does not
> support .gnu.hash, so the default (sysv) is the correct value. What's
> worse, there is a bug in the older version of GNU ld used in the
> current Android toolchain that messes up .hash section whenever
> .gnu.hash is present.


This generally looks fine, feel free to commit. I would move the comment
you added to be with the comment about MIPS not supporting this construct.
They're both comments on the condition block, not on the IsAndroid or
IsMips variables. The variables are pretty clear. =D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120113/6cd3c32a/attachment.html>

More information about the cfe-commits mailing list