[cfe-commits] r147933 - in /cfe/trunk: lib/CodeGen/CodeGenFunction.cpp test/CodeGen/vla-4.c

Chandler Carruth chandlerc at google.com
Wed Jan 11 01:25:12 PST 2012

On Wed, Jan 11, 2012 at 12:19 AM, Abramo Bagnara
<abramo.bagnara at gmail.com>wrote:

> Author: abramo
> Date: Wed Jan 11 02:19:46 2012
> New Revision: 147933
> URL: http://llvm.org/viewvc/llvm-project?rev=147933&view=rev
> Log:
> Fixed VLA code generation.

In general, it would help a lot to be more descriptive about what went
wrong previously in commit logs. It's often not obvious from the patch what
the prior misbehavior was, and having that context makes it faster to
review these changes.

> Added:
>    cfe/trunk/test/CodeGen/vla-4.c

Also, rather than having now 4 test files for vlas, it would be better to
add these test cases and their checks to existing files, and potentially
even collapse the files we already have.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120111/a69548b2/attachment.html>

More information about the cfe-commits mailing list