[cfe-commits] r146413 - in /cfe/trunk: include/clang/Basic/BuiltinsHexagon.def include/clang/Basic/LangOptions.def include/clang/Basic/TargetBuiltins.h include/clang/Driver/CC1Options.td include/clang/Driver/Options.td lib/Basic/Targets.cpp lib/C

jverma at codeaurora.org jverma at codeaurora.org
Mon Jan 9 14:24:45 PST 2012

Hi All,

I have changed the implementation of the CPU flag validation for the
Hexagon backend. Earlier, the clang driver performed the check and
asserted on invalid inputs. In the new implementation, the driver passes
the last CPU flag (or sets to "v4" if not specified) to the compiler (and
also to the assembler and linker which perform their own check) instead of
asserting on incorrect values. This patch changes the setCPU function for
the Hexagon backend in clang/lib/Basic/Targets.cpp which causes the
compiler to error out on incorrect CPU flag values.

Please find attached the patch file for the fix.


> On Mon, Dec 19, 2011 at 1:02 PM,  <jverma at codeaurora.org> wrote:
>> Hi All,
>> I have made the changes to remove assertions in the Hexagon backend
>> specific clang driver. Instead of asserting on invalid arch name, it has
>> been modified to use the default value.
>> Please find attached the patch file for the fix.
> Silently ignoring unexpected options is confusing for users; a
> diagnostic would be better.
> -Eli
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20120109/ba52dce5/attachment.txt>

More information about the cfe-commits mailing list