[cfe-commits] r147655 - in /cfe/trunk: lib/CodeGen/CGBuiltin.cpp test/CodeGen/no-builtin.c

[Richard Smith]

On Fri, January 6, 2012 15:58, David Chisnall wrote:
> On 6 Jan 2012, at 15:56, Richard Smith wrote:
>> On Fri, January 6, 2012 15:39, David Chisnall wrote:
>>> Then I am confused - the test case in the bug report failed for me before
>>>  making that change and passed after that change...
>>
>> Were you running it through FileCheck? It's only checking for 'cos' in the
>> output, which will naturally exist since you define an extern function with
>> that name.
>
> Ah, that's a bug in the test then.  I was only checking whether the change
> fixed the issue in the bug report.

Nonetheless, that was not the problem I was originally observing. In my tests,
a call to @cos appears in main with -fno-builtin, and does not appear without,
for your testcase, with or without your patch. I've tried a freebsd triple,
and I see the same behavior. Can you give a command-line using -fno-builtin
for which we do not produce a call to @cos, prior to your patch, so I can see
if our results match?

- Richard