[cfe-commits] [PATCH] bindings/python/clang/cindex.py

Anders Waldenborg anders at 0x63.nu
Wed Jan 4 00:24:56 PST 2012


On Fri, Dec 30, 2011 at 7:18 PM, Tom Schuster wrote:
> So rafael (Thanks!), landed the CursorKind part of this, but suggested
> that somebody should comment on the get_referenced name.

I think you should drop the _cursor suffix, to make it similar to
get_declaration, which also returns a cursor (or None). I also suggest
adding an is_reference method (wrapping clang_isReference) to make it
fully symmetric to declaration cursors.

Btw, I also posted a patch for the missing cursorkind Dec 19:

[PATCH 1/2] PYTHON: Add missing attribute cursorkinds

Your had a better name for ASM_LABEL so good thing that mine got
dropped. However my patch also included a testcase which would make
sense to have merged.

 anders



More information about the cfe-commits mailing list