[cfe-commits] r146413 - in /cfe/trunk: include/clang/Basic/BuiltinsHexagon.def include/clang/Basic/LangOptions.def include/clang/Basic/TargetBuiltins.h include/clang/Driver/CC1Options.td include/clang/Driver/Options.td lib/Basic/Targets.cpp lib/C

[jverma at codeaurora.org]

Hi Eli,

You are right. It should be errored out or at least the user needs to be
warned. However, the way our setup is structured, the 'march/mcpu' is
parsed separately for the compiler, assembler and linker argument setup
and causes the error being reported from all three. I am trying to find a
way to have the error reported just once, but don't know how to do it at
this point. Any suggestions will be highly appreciated.

I had a look at ARM's handling of -mcpu and -march flags, but they are
validated by cc1 and the assembler respectively and not the driver.

Thanks,
Jyotsna


> On Mon, Dec 19, 2011 at 1:02 PM,  <jverma at codeaurora.org> wrote:
>> Hi All,
>>
>> I have made the changes to remove assertions in the Hexagon backend
>> specific clang driver. Instead of asserting on invalid arch name, it has
>> been modified to use the default value.
>>
>> Please find attached the patch file for the fix.
>
> Silently ignoring unexpected options is confusing for users; a
> diagnostic would be better.
>
> -Eli
>