[cfe-commits] [patch] confusing ARC diagnostic categories' names.

[Ted Kremenek]

Committed in r146483.  Thanks!

On Dec 13, 2011, at 5:26 AM, Jean-Daniel Dupas wrote:

> Then fell free to apply it. I don't have commit right ;-)
> 
> Le 13 déc. 2011 à 07:02, Ted Kremenek a écrit :
> 
>> Sounds great to me.
>> 
>> On Dec 12, 2011, at 3:37 PM, Jean-Daniel Dupas wrote:
>> 
>>> Hello,
>>> 
>>> 
>>> Actually, clang defines 2 ARC diagnostic group with similar names (You can run "clang --print-diagnostic-categories" to see both categories) : 
>>> - ARC Issue
>>> - Automatic Reference Counting Issue
>>> 
>>> The first one is defined in "DiagnosticSemaKinds" and the second one in "DiagnosticParseKinds"
>>> 
>>> If changing the name does not break anything, I propose to rename the first one "ARC Semantic Issue", and the second one "ARC Parse Issue" to be consistent with other generic categories ("Semantic Issue" and "Parse Issue").
>>> 
>>> Regards
>>> 
>>> -- Jean-Daniel
>>> 
>>> 
>>> 
>>> <arc_diag_cat.patch>_______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> 
> 
> -- Jean-Daniel
> 
> 
> 
>