[cfe-commits] r145736 - in /cfe/trunk/lib/CodeGen: CGClass.cpp CGException.cpp CGExpr.cpp CGExprCXX.cpp CGStmt.cpp CGValue.h CodeGenFunction.h

[Eli Friedman]

On Fri, Dec 2, 2011 at 8:33 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Fri, Dec 2, 2011 at 5:37 PM, John McCall <rjmccall at apple.com> wrote:
>> On Dec 2, 2011, at 4:54 PM, Eli Friedman wrote:
>>> Author: efriedma
>>> Date: Fri Dec  2 18:54:26 2011
>>> New Revision: 145736
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=145736&view=rev
>>> Log:
>>> Track alignment in AggValueSlot.  No functional change in this patch, but I'll be introducing uses of the specified alignment soon.
>>
>> Thanks!  Please make it take and vend the alignment as a CharUnits, though.
>
> Actually, I'm starting to rethink this... would it make sense to
> always ensure that an AggValueSlot is always appropriately aligned?

Hmm... thinking about it a bit more, it really isn't that much work to
allow under-aligned AggValueSlots.  I'm wondering about RValue,
though... it feels like we could go either way on that: either say
they can be completely represented by a single llvm::Value*, or allow
essentially a complete LValue to be represented by one. I'm sort of
leaning towards the "complete LValue" approach, but it does make using
RValue a bit more complicated.

-Eli