[cfe-commits] Add the support for AddressSanitizer on Darwin into the driver.

[Chandler Carruth]

On Thu, Dec 1, 2011 at 1:28 AM, Alexander Potapenko <glider at google.com>wrote:

> Attached the new version, PTAL
>
> > +  if (Args.hasArg(options::OPT_faddress_sanitizer)) {
> > Please
> >
> use Args.hasFlag(options::OPT_faddress_sanitizer, options::OPT_fno_address_sanitizer,
> > false))
> Done
> >
> > and hide the flag checking inside addAsanRTDarwinExe/etc
> Then this should be something like "maybeAddAsan...", because this
> function is called unconditionally and other devs may think that we
> always add ASan.
> I've renamed the correspoding Linux function as well.
>

I don't agree... The function is responsible for adding what Address
Sanitizer needs, and it needs nothing if disabled. This matches several
other 'addFoo' functions in the driver.


>
> > +const int AsanIfaceFnsSize = sizeof(AsanIfaceFns) / sizeof(char*);
> > +const char *AsanIfaceFns[13] = {
> > I would make these function-scope (if we end up needing them).
> I've ended up using -undefined dynamic_lookup.
> Indeed, if someone has an undefined symbol in this dynamic library,
> let him catch this in another compiler mode.
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111201/c8c87c1c/attachment.html>