[cfe-commits] [Request for review] Removing redundant implicit casts in the AST

[Benjamin Kramer]

On 28.11.2011, at 10:04, Nicola Gigante <nicola.gigante at gmail.com> wrote:

>
> Il giorno 21/nov/2011, alle ore 17:21, Nicola Gigante ha scritto:
>
>>>
>>> Yes, this is looking good. The patch didn't quite apply cleanly; if you can bring it up to date with mainline I'll be happy to commit it, thanks!
>>>
>>> Super-minor nit:
>>>
>>> +    // CheckStaticCast _may_ have already created the cast node. Let's check
>>> +    if(CastNodesCreated) {
>>>
>>> Please put a space after the "if" and before the "(" (in a bunch of places).
>>>
>>
>> Ok!
>> This should be the final patch. It applies to r145038 and pass the tests
>> (there is one that fails in any case in that revision, but it has nothing
>> to do with my patch).
>>
>
> ping? I've recently been granted "commit after approval" rights by Chris,
> so I can commit the patch myself if you agree.

Go ahead, Doug already approved your change.

-Ben

>
> Nicola
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits