[cfe-commits] [Request for review] Removing redundant implicit casts in the AST

Nicola Gigante nicola.gigante at gmail.com
Mon Nov 21 08:21:35 PST 2011

> Yes, this is looking good. The patch didn't quite apply cleanly; if you can bring it up to date with mainline I'll be happy to commit it, thanks!
> Super-minor nit:
> +    // CheckStaticCast _may_ have already created the cast node. Let's check
> +    if(CastNodesCreated) {
> Please put a space after the "if" and before the "(" (in a bunch of places).

This should be the final patch. It applies to r145038 and pass the tests
(there is one that fails in any case in that revision, but it has nothing
to do with my patch).

> 	- Doug


-------------- next part --------------
A non-text attachment was scrubbed...
Name: cast.patch
Type: application/octet-stream
Size: 31618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111121/a5952929/attachment.obj>
-------------- next part --------------

More information about the cfe-commits mailing list