[cfe-commits] r143770 - in /cfe/trunk/lib/Driver: CMakeLists.txt ToolChains.cpp

[Tanya Lattner]

On Nov 16, 2011, at 7:04 AM, Douglas Gregor wrote:

> 
> On Nov 15, 2011, at 11:20 PM, Chandler Carruth wrote:
> 
>> On Tue, Nov 15, 2011 at 11:19 PM, Chandler Carruth <chandlerc at google.com> wrote:
>> Sending this to Tanya and Doug; Bill is currently on vacation IIUC.
>> 
>> What do you folks think about including this in RC4? I have no strong opinions here. I don't know if MSVC building is really a goal of 3.0.
>> 
>> For reference, This patch was mainline before RC3. I didn't realize how important it was, or I would have brought it up before.... But then no one else has complained about RC3 either, so I get the sense that no one is trying to build RC3 with MSVC….
> 
> Do we not have any release testers building with MSVC? That would be a pretty big gap in our testing.
> 
> We should take this change; it's obviously well-tested, and it only affects CMake with MSVC, so the risk of breakage to anything critical is roughly zero.
> 

MSVC is not an officially supported platform for our releases. I normally would tell you "No" in this situation regardless of risk as its way too late in the release cycle to be asking me to add more patches.

But since, its ifdef-ed and I'm in a good mood, I'll put it in.

Yes, most of this is sarcasm, but seriously.. no more patches unless it meets the release blocker criteria. :)

-Tanya


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111116/a67db7d2/attachment.html>