[cfe-commits] adding "-fasan" flag

[John McCall]

On Nov 15, 2011, at 8:22 PM, Kostya Serebryany wrote:
> On Tue, Nov 15, 2011 at 6:40 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Tue, Nov 15, 2011 at 6:22 PM, Kostya Serebryany <kcc at google.com> wrote:
> > Hello,
> > Please review the following patch which adds -fasan (AddressSanitizer) flag
> > to clang.
> > (Mostly prepared by Chandler Carruth).
> > The LLVM part of AddressSanitizer has been submitted as r144758.
> > This patch will allow to enable AddressSanitizer from the clang command
> > line.
> > http://codereview.appspot.com/5396042
> > Coming next in separate patches:
> >   - a patch to clang driver to pass linker flags for AddressSanitizer
> > (small)
> >   - the run-time library and the tests (big)
> > Thanks,
> > --kcc
> 
> I would prefer -faddress-sanitizer over -fasan; shorter isn't really
> better here.
> 
> Changing the flag name would sad.
>   - The logo of AddressSanitizer is a "Pheasant eating a Bug". "Fasan" means "Pheasant" in several European languages (also, "Фазан" in Russian).
> - Quite a few existing users will have to change their makefiles. 

Them's the breaks of early adoption.

-fasan is not an acceptable name, no matter how nice the pun.  And I do appreciate the pun.

John.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111115/d5b1df73/attachment.html>