[cfe-commits] r144590 - in /cfe/trunk: lib/Driver/Tools.cpp test/Driver/crash-cleanup.c

[Douglas Gregor]

On Nov 14, 2011, at 3:50 PM, Eli Friedman wrote:

> On Mon, Nov 14, 2011 at 3:24 PM, Matt Beaumont-Gay <matthewbg at google.com> wrote:
>> Author: matthewbg
>> Date: Mon Nov 14 17:24:52 2011
>> New Revision: 144590
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=144590&view=rev
>> Log:
>> Don't track depfiles as result files which need to be cleaned up on failure.
>> 
>> This is a partial revert of r143846. While cleaning up after a crash is
>> probably a good idea, we were also deleting .d files if the compilation failed
>> due to invalid input, which is not the desired behavior. The test is XFAIL'd
>> until the cleanup code can be reworked to do the right thing.
> 
> We can't, in general, compute the dependencies for an invalid C file:
> since it isn't valid, we can't be sure what files it is supposed to be
> referencing.  I mean, we could prefer to generate an empty .d file in
> the general case, to satisfy quirky build systems...

Practically speaking, most errors are parsing or semantic errors that have no impact on the dependencies of the file.

	- Doug