[cfe-commits] r144058 - /cfe/trunk/lib/Sema/SemaPseudoObject.cpp

[Benjamin Kramer]

On 08.11.2011, at 03:15, David Blaikie <dblaikie at gmail.com> wrote:

>> Revert r143972, which didn't actually compile under -Wnon-virtual-dtor.
>
> Curious. Which version of gcc are you using? My cursor test showed
> this working for a simple example in gcc 4.6

GCC's behavior was fixed in 4.3 or 4.4
(http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7302)

Also, in GCC 4.0 it used to be enabled with -Wall, which is the reason
why we have unneccessary virtual dtors all over the place. They're
harmless in general but can create dead code bloat if it's in a
templated class with many instantiations.

- Ben