[cfe-commits] r144058 - /cfe/trunk/lib/Sema/SemaPseudoObject.cpp

Matt Beaumont-Gay matthewbg at google.com
Mon Nov 7 17:53:17 PST 2011


Author: matthewbg
Date: Mon Nov  7 19:53:17 2011
New Revision: 144058

URL: http://llvm.org/viewvc/llvm-project?rev=144058&view=rev
Log:
Revert r143972, which didn't actually compile under -Wnon-virtual-dtor.

(TIL: -Wnon-virtual-dtor is not in -Wall.)

Modified:
    cfe/trunk/lib/Sema/SemaPseudoObject.cpp

Modified: cfe/trunk/lib/Sema/SemaPseudoObject.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaPseudoObject.cpp?rev=144058&r1=144057&r2=144058&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaPseudoObject.cpp (original)
+++ cfe/trunk/lib/Sema/SemaPseudoObject.cpp Mon Nov  7 19:53:17 2011
@@ -141,6 +141,8 @@
       : S(S), ResultIndex(PseudoObjectExpr::NoResult),
         GenericLoc(genericLoc) {}
 
+    virtual ~PseudoOpBuilder() {}
+
     /// Add a normal semantic expression.
     void addSemanticExpr(Expr *semantic) {
       Semantics.push_back(semantic);
@@ -179,9 +181,6 @@
     virtual ExprResult buildGet() = 0;
     virtual ExprResult buildSet(Expr *, SourceLocation,
                                 bool captureSetValueAsResult) = 0;
-
-  protected:
-    ~PseudoOpBuilder() {}
   };
 
   /// A PseudoOpBuilder for Objective-C @properties.





More information about the cfe-commits mailing list