[cfe-commits] [llvm-commits] Ping^2: Fix for bug 11060: configure --target does not work

Sebastian Pop spop at codeaurora.org
Tue Nov 1 11:15:42 PDT 2011


On Tue, Nov 1, 2011 at 12:23 PM, Eric Christopher <echristo at apple.com> wrote:
>
> On Nov 1, 2011, at 9:44 AM, Sebastian Pop wrote:
>
>> Hi,
>>
>> On Thu, Oct 27, 2011 at 10:01 PM, Joerg Sonnenberger
>> <joerg at britannica.bec.de> wrote:
>>>> 2. derive LLVM_HOSTTRIPLE from $target as you proposed, then rename
>>>> LLVM_HOSTTRIPLE into something more meaningful, like what I proposed
>>>> LLVM_DEFAULT_TARGET.
>>> The second makes sure that everything is consistent from the start, no
>>> chance of forgetting something in the middle. So yes, (2) is fine with
>>> me, but the "rename to something meaningful" part has to be part of a
>>> larger API change, since the host vs target misnaming is very sticky.
>>
>> Here are the amended patches for this change.
>> Tested on amd64-linux and cross to ARM.
>> Ok with these changes?
>
> Yep. Need me to commit them?

Yes please.
Should I contact Chris to get svn write access as well?

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum



More information about the cfe-commits mailing list