[cfe-commits] [llvm-commits] Ping^2: Fix for bug 11060: configure --target does not work

Sebastian Pop spop at codeaurora.org
Tue Nov 1 09:44:33 PDT 2011


Hi,

On Thu, Oct 27, 2011 at 10:01 PM, Joerg Sonnenberger
<joerg at britannica.bec.de> wrote:
>> 2. derive LLVM_HOSTTRIPLE from $target as you proposed, then rename
>> LLVM_HOSTTRIPLE into something more meaningful, like what I proposed
>> LLVM_DEFAULT_TARGET.
> The second makes sure that everything is consistent from the start, no
> chance of forgetting something in the middle. So yes, (2) is fine with
> me, but the "rename to something meaningful" part has to be part of a
> larger API change, since the host vs target misnaming is very sticky.

Here are the amended patches for this change.
Tested on amd64-linux and cross to ARM.
Ok with these changes?

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-derive-LLVM_HOSTTRIPLE-from-target.patch
Type: text/x-diff
Size: 2228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111101/194e1429/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-rename-LLVM_HOSTTRIPLE-into-LLVM_DEFAULT_TARGET_TRIP.patch
Type: text/x-diff
Size: 6905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111101/194e1429/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-rename-getHostTriple-into-getDefaultTargetTriple.patch
Type: text/x-diff
Size: 8530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111101/194e1429/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-rename-getHostTriple-into-getDefaultTargetTriple-in-.patch
Type: text/x-diff
Size: 4477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111101/194e1429/attachment-0003.patch>


More information about the cfe-commits mailing list