[cfe-commits] [llvm-commits] Ping^2: Fix for bug 11060: configure --target does not work

[Sebastian Pop]

On Thu, Oct 27, 2011 at 10:01 PM, Joerg Sonnenberger
<joerg at britannica.bec.de> wrote:
>> 1. create LLVM_DEFAULT_TARGET from $target, and remove LLVM_HOSTTRIPLE
>> (I'll let you post a patch that removes LLVM_HOSTTRIPLE as you said
>> that HOST is unused)
>>
>> 2. derive LLVM_HOSTTRIPLE from $target as you proposed, then rename
>> LLVM_HOSTTRIPLE into something more meaningful, like what I proposed
>> LLVM_DEFAULT_TARGET.
>>
> The second makes sure that everything is consistent from the start, no

I fail to see how 2. will be consistent "from the start", when we will be
calling HOST the value in $target, but anyways...

> chance of forgetting something in the middle. So yes, (2) is fine with
> me, but the "rename to something meaningful" part has to be part of a
> larger API change, since the host vs target misnaming is very sticky.

That's fine with me, as I consider that the two paths are equivalent, leading
to the same state.  It will take me quite some time to come with patches for
the second option.  Eric, do you want to wait for another week or so until I
get the new set of patches out?  Or do you want to go with the first option?
It's your take Eric, as you are the maintainer here.

Also, is there consensus that changing "host" into "target" all over the place
(of course, only where it is meaningful to change) is the right thing to do?

Thanks,
Sebastian
--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum