[cfe-commits] [patch] fix for PR11216

Douglas Gregor dgregor at apple.com
Tue Oct 25 07:22:59 PDT 2011

On Oct 24, 2011, at 10:59 PM, David Blaikie wrote:

> Here's a fairly non-intrusive fix for PR11216: "Can't derive from a
> decltype-specifier" including a couple of test cases & some updated
> naming/comments.
> Let me know if this looks OK & I'll check it in.

It looks pretty good, but I have two requests:

1) The "else" that handles class-names is really long. I think the flow would be better if decltype() was handled completely in its own "if" early on, since it shares so little code with the class-name case.

2) Please add some tests that have a dependent decltype expression, to make sure template instantiation works. I'm sure it will, but...

	- Doug

More information about the cfe-commits mailing list