[cfe-commits] r142685 - in /cfe/trunk: lib/Analysis/ThreadSafety.cpp test/SemaCXX/warn-thread-safety-analysis.cpp

Chandler Carruth chandlerc at google.com
Fri Oct 21 15:09:37 PDT 2011

On Fri, Oct 21, 2011 at 1:51 PM, DeLesley Hutchins <delesley at google.com>wrote:

> -    // destructors not implemented yet...
> -    Foo foo; // \
> -    // expected-warning {{mutex 'fooMu' is still locked at the end of
> function}}
> +    Foo foo;

It would be good to add more coverage to this test. For example, currently
if I disable both the constructor and destructor processing, the test still
passes. Can we cause some warnings to be emitted as well, and the lock to
actually be used?

Maybe reference a guarded variable, and call a function with a different set
of required locks?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111021/c4e44fe3/attachment.html>

More information about the cfe-commits mailing list