[cfe-commits] [Patch] suggest %zu for size_t args to printf (PR11152)

Ted Kremenek kremenek at apple.com
Mon Oct 17 11:18:45 PDT 2011


On Oct 17, 2011, at 11:15 AM, Eli Friedman wrote:

> On Mon, Oct 17, 2011 at 1:59 AM, Hans Wennborg <hans at chromium.org> wrote:
>> Hi all,
>> 
>> The attached patch is for PR11152.
>> 
>> It makes PrintfSpecifier::fixType() choose "%zu" for size_t, etc.,
>> rather than looking at the underlying type and suggesting "%llu" or
>> other platform-specific length modifiers. This is for C99, C1X and
>> C++11.
>> 
>> Please let me know if this is ok to land.
> 
> The one thing I am concerned about is that on Windows, this might end
> up suggesting modifiers which don't actually work.  Not sure what we
> can do about that, though.

We can check if the target is win32 when issuing these fixits...



More information about the cfe-commits mailing list