[cfe-commits] RFC: Half floating point support

Eli Friedman eli.friedman at gmail.com
Fri Oct 14 16:05:36 PDT 2011


On Fri, Oct 14, 2011 at 11:29 AM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:
>>> BuildFunctionType seems to work only in C++ case, no? Right now it's
>>> called from 2 places only, one - in SemaTemplateDeduction.cpp and
>>> another one - from TreeTransform.h.
>>>
>>> It's never called on fp16-sema.c. Am I missing something?
>>
>> No, you're not missing anything; John is describing how it should
>> work, you're describing how it actually does at the moment. :)
> Ok, what should I do then :) ? I'm seeing that typedefs are indeed
> missed, I can probably factor out my checks into separate helper
> routine and call it similar to DiagnoseUnusedParameters, putting FIXME
> about BuildFunctionType.

Put it into BuildFunctionType and GetFullTypeForDeclarator, and put a
FIXME on the version in GetFullTypeForDeclarator.

-Eli



More information about the cfe-commits mailing list