[cfe-commits] r141942 - /cfe/trunk/include/clang/AST/Type.h

Ted Kremenek kremenek at apple.com
Fri Oct 14 09:17:20 PDT 2011

I don't really understand your comments.

The doxygen comments only have value for generating documentation when they are paired with the actual things they are documenting.  Having a bunch of comments that look like they are documenting non-existent members looks like turds in the code to me.

Sent from my iPad

On Oct 13, 2011, at 9:39 PM, John McCall <rjmccall at apple.com> wrote:

> On Oct 13, 2011, at 9:15 PM, Ted Kremenek wrote:
>> Author: kremenek
>> Date: Thu Oct 13 23:15:15 2011
>> New Revision: 141942
>> URL: http://llvm.org/viewvc/llvm-project?rev=141942&view=rev
>> Log:
>> Move doxygen comments to pair with the actual values.
> Okay, but now these comments aren't in the logical place that I would look
> for them to figure out the class layout for a FunctionProtoType, and the
> layout information seems completely out of context when applied to the
> members in ExtProtoInfo.
> John.

More information about the cfe-commits mailing list