[cfe-commits] RFC: Half floating point support

John McCall rjmccall at apple.com
Thu Oct 13 22:03:31 PDT 2011

On Oct 8, 2011, at 3:08 AM, Anton Korobeynikov wrote:
> Attached is the updated patch. Now with tests. They include:

This mostly looks very good, thanks!

+  // Do not allow returning half FP value.
+  if (R->getAs<FunctionType>()->getResultType()->isHalfType()) {

This, and the analogous logic for parameters, should really be done in BuildFunctionType, or else it won't happen for function pointers/references, typedefs of function types, and templates that happen to instantiate argument or return types this way.  You should also ensure that the logic kicks in for unprototyped function types, which will require some special-case logic.


More information about the cfe-commits mailing list