[cfe-commits] [PATCH] Implementation quantity limits to prevent crashes

Aaron Ballman aaron at aaronballman.com
Wed Sep 21 20:45:09 PDT 2011


On Wed, Sep 21, 2011 at 8:11 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> Also, the diagnostic wording was taken from MSVC, but could likely be
>> improved.  Suggestions welcome.
>
> I would say something more along the lines of "parser recusion limit
> reached"; using the term "stack overflow" makes it sound like a bug in
> the compiler.

Here is a revised patch with the new diagnostic wording.

Thank you for the review!

~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ParserLimits.diff
Type: application/octet-stream
Size: 38013 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110921/8fc3dfac/attachment.obj>


More information about the cfe-commits mailing list